-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seed recovery 🌱 #300
Merged
Seed recovery 🌱 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
- Coverage 13.47% 13.21% -0.27%
==========================================
Files 162 167 +5
Lines 5893 6169 +276
Branches 1624 1685 +61
==========================================
+ Hits 794 815 +21
- Misses 4954 5208 +254
- Partials 145 146 +1 ☔ View full report in Codecov by Sentry. |
KKA11010
requested review from
BilligsterUser,
onoomobo,
callebtc,
gandlafbtc and
turizspace
February 6, 2024 15:34
callebtc
reviewed
Feb 6, 2024
onoomobo
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a PR for the fixed GPT errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to support the restore method provided by the
cashu-ts
library. I introduce this as an optional feature in eNuts with room for improvements. Most of the additions are related to the frontend and translations.Any reviews or feedback you can provide would be very helpful!
Please take note of the following files that have been added/modified and require attention:
src/wallet/index.ts
> diffsrc/storage/store/restore.ts
> diffsrc/components/hooks/Restore.tsx
> diffFixes #140
Changes
cashu-ts
to version0.9.0
keysetId
, which increments with each validproof
received. See counterwallet.restore(start, count, keysetId?)
in a recursive manner. See restore hook and recursive functionwallet.restore(start, count, keysetId?)
is currently not used!